• This PR has its tests “red” because of a Bazel failure • As we all know, Bazel is a peripheral tier of support and should not impede general progress • I know we don’t block merge on red tests, but the general user doesn’t know what’s a test that needs to pass and those that don’t • It’s confusing for reviewers and authors what to ignore and may cause people ignoring genuine problems • This has been brought up numerous times in buildbot quality conversations (@gkistanova @akorobeynikov @tstellar) and is not a good tihng • Similar bots (clang-tidy) are being proposed but we have not resolved how to represent that in Github to actively help authors and reviewers how to interpret the result

Article Summaries:

  • This PR has its tests “red” because of a Bazel failure. As we all know, Bazel is a peripheral tier of support and should not impede general progress. I know we don’t block merge on red tests, but the general user doesn’t know what’s a test that needs to pass and those that don’t. It’s confusing for reviewers and authors what to ignore and may cause people ignoring genuine problems. This has been brought up numerous times in buildbot quality conversations (@gkistanova @akorobeynikov @tstellar) and is not a good tihng. Similar bots (clang-tidy) are being proposed but we have not resolved how to

Sources: